hliao marked an inline comment as done. hliao added inline comments.
================ Comment at: clang/test/CodeGenCUDA/amdgpu-visibility.cu:1 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fcuda-is-device -fapply-global-visibility-to-externs -fvisibility default -emit-llvm -o - %s | FileCheck --check-prefix=CHECK-DEFAULT %s +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fcuda-is-device -fapply-global-visibility-to-externs -fvisibility protected -emit-llvm -o - %s | FileCheck --check-prefix=CHECK-PROTECTED %s ---------------- yaxunl wrote: > do we need -fapply-global-visibility-to-externs? that's so far the option applied for both AMDGPU & HIP (targetting non-MS) by default in clang frontend. Check AMDGPUToolChain::addClangTargetOptions and HIPToolChain::addClangTargetOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61194/new/ https://reviews.llvm.org/D61194 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
