ilya-biryukov added inline comments.
================
Comment at: clangd/Diagnostics.cpp:115
+ const SourceManager &SM = Info.getSourceManager();
+ std::vector<SourceLocation> IncludeStack;
+ auto GetIncludeLoc = [&SM](SourceLocation SLoc) {
----------------
replace `vector<SourceLocation>` with `SourceLocation` now that we only need
one of the locations.
================
Comment at: unittests/clangd/DiagnosticsTests.cpp:748
+ UnorderedElementsAre(
+ Diag(Main.range(), "Error in include c.h: C++ requires a "
+ "type specifier for all declarations")));
----------------
NIT: maybe quote the name of the header for better readability: `error in
include 'c.h' ...`?
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59302/new/
https://reviews.llvm.org/D59302
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
