compnerd added inline comments.
================
Comment at: lib/CodeGen/CGObjCMac.cpp:3961
+ // linkage so that the linker preserves the symbol name.
+ llvm::GlobalValue::LinkageTypes LT =
+ Section.empty() || Section.startswith("__DATA")
----------------
Hmm, when would you have a metadata variable not in the `__DATA` segment?
================
Comment at: lib/CodeGen/CGObjCMac.cpp:7266
+ false,
+ CGM.getTriple().isOSBinFormatMachO()
+ ? llvm::GlobalValue::InternalLinkage
----------------
Is there a reason to not make this and the other instances `Internal`
irrespective of the object file format?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61454/new/
https://reviews.llvm.org/D61454
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
