lebedev.ri added reviewers: aaron.ballman, lebedev.ri. lebedev.ri added a comment.
I recommend to split this into two parts - changing `PragmaIntroducerKind Introducer` to `struct NameMe { PragmaIntroducerKind Kind; SourceLocation Loc};`, and the actual openmp change. For that change, just basing off the clang-tidy diff, neither variant is ideal, so i'd like to see the proposed use-case. ================ Comment at: clang/include/clang/Lex/Pragma.h:68-69 StringRef getName() const { return Name; } virtual void HandlePragma(Preprocessor &PP, PragmaIntroducerKind Introducer, + SourceLocation IntroducerLoc, Token &FirstToken) = 0; ---------------- `PragmaIntroducerKind Introducer` and `SourceLocation IntroducerLoc` are talking about the same thing, are they not? They should be put into some new struct, instead of adding a new parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61509/new/ https://reviews.llvm.org/D61509 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits