riccibruno marked an inline comment as done. riccibruno added inline comments.
================ Comment at: include/clang/AST/JSONNodeDumper.h:55 + } + + /// Add a child of the current node with an optional label. ---------------- aaron.ballman wrote: > riccibruno wrote: > > Perhaps you should perfect-forward `DoAddChild` ? > Hmm, if I was doing that, I'd probably prefer to use `std::invoke()` to call > the function, but we can't use that because it's C++17. Do you have concerns > if I don't make that change just yet (we don't do it from `TextNodeDumper` > either). Sounds good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60910/new/ https://reviews.llvm.org/D60910 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
