rnk added a comment. I'm a little concerned about overloading the code model this way. Currently we have the levels tiny, small, medium, large. Default is the same as small in every way so far as I'm aware. On COFF, the code models are currently untested, so far as I know, and I've been assuming that any usage of the non-small code model more or less implies ELF, and that it would be reasonable to emit wrong code or a fatal error on such codepaths during LLVM codegen. Maybe we have some use cases for the other code models in MCJIT.
With this change, "default" is now a new level that implies not small, but not medium either. Basically, I'm concerned that if we add this feature under -mcode-model=small, users will play with -mcode-model=medium, and they'll run into LLVM backend fatal errors, crashes, or wrong code. So, before we do this, I'd like to do some testing of COFF with the other code models, and make sure that LLVM does something reasonable in the other models, before we encourage users to use this flag. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61670/new/ https://reviews.llvm.org/D61670 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
