rnk added a comment.

In D61646#1495517 <https://reviews.llvm.org/D61646#1495517>, @thakis wrote:

> Did I get the bug right that this adds almost 400kB to every file that 
> includes stddef.h?


I didn't put much confidence in that number because it was with 
`-frewrite-includes` which adds line markers etc, but I did this and now I'm 
not sure I'm in favor anymore:

  $ du -h /c/Program\ Files\ \(x86\)/Microsoft\ Visual\ 
Studio/2019/Professional/VC/Tools/MSVC/14.20.27508/include/sal.h
  212K    /c/Program Files (x86)/Microsoft Visual 
Studio/2019/Professional/VC/Tools/MSVC/14.20.27508/include/sal.h

I'm guessing that the main dependency that's leaking out of msvc's stddef.h is 
in fact sal.h, but I think we really *don't* want to include that if we can 
avoid it. I think we'd be doing users a favor by keeping those macros out of 
their compilation if they don't need them.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61646/new/

https://reviews.llvm.org/D61646



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to