ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments.
================ Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:78 + /// For debugging purposes. + std::string str() const; + ---------------- sammccall wrote: > ilya-biryukov wrote: > > sammccall wrote: > > > (do we need to have two names for this version?) > > You mean to have distinct names for two different overloads? > > I wouldn't do it, they both have fairly similar outputs, could add a small > > comment that the one with SourceManager should probably be preferred if you > > have one. > > > No sorry, I meant do we need both str() and operator<< one can type `str()` in debugger, `operator <<` is for convenience when one is already using streams. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https://reviews.llvm.org/D59887 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
