gtbercea marked 2 inline comments as done.
gtbercea added inline comments.

================
Comment at: lib/Headers/openmp_wrappers/__clang_openmp_math_declares.h:17
+  #include <cstdlib>
+  #include <stdlib.h>
+#endif
----------------
jdoerfert wrote:
> Why do we need the stdlib includes again?
They are both prone to abs inclusion.

We need them here to control the order in which they are included relative to 
the forward_declares header.


================
Comment at: test/Headers/Inputs/include/cstdlib:2
+#pragma once
+typedef __SIZE_TYPE__ size_t;
----------------
jdoerfert wrote:
> Where is this used? Are there tests missing?
I'll remove it.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61765/new/

https://reviews.llvm.org/D61765



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to