martong marked 8 inline comments as done. martong added a comment. Thanks for the review Alexei!
================ Comment at: clang/unittests/AST/ASTImporterGenericRedeclTest.cpp:20 + +// FIXME put these structs and the tests rely on them into their own separate +// test file! ---------------- a_sidorin wrote: > Is this FIXME obsolete now? Yes, that's correct, thank you for finding it! ================ Comment at: clang/unittests/AST/ASTImporterVisibilityTest.cpp:49 + ::testing::WithParamInterface<std::tuple<ArgVector, const char *>>; +// Fixture to test the redecl chain of Decls with the same visibility. Gtest +// makes it possible to have either value-parameterized or type-parameterized ---------------- a_sidorin wrote: > Double spaces in the end of sentences look a bit strange. Ok I removed them. (Note, this is the result of some autoformatting option in vim, could not discover which specific setting causes the insertion of double spaces.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61786/new/ https://reviews.llvm.org/D61786 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
