jdoerfert added a comment.

Two small changes and then it is fine with me. @tra ?

1. we need to use ifdef to not define clock
2. Can you switch the include order in 
`test/Headers/nvptx_device_math_functions.cpp`?

P.S. I'm currently at the OpenMP standard meeting to get the OpenMP variants 
fixed.
Once done, we should prioritize the implementation.
Excluding non-math functions in the cuda headers is not perfect...


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61765/new/

https://reviews.llvm.org/D61765



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to