gribozavr added inline comments.
================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:457
+ forwardDiagnostic(Info);
+ return;
+ }
----------------
Indentation is 2 spaces.
================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:472
if (Info.hasSourceManager())
checkFilters(Info.getLocation(), Info.getSourceManager());
}
----------------
It seems like the `checkFilters` call should not be skipped even if we have
another diagnostic engine.
================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.h:197
+ DiagnosticIDs::Level L;
+ std::string string;
+ };
----------------
Sorry, it is unclear what this struct is, and what its members are, especially
given that the member names are `L` and `string`...
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61487/new/
https://reviews.llvm.org/D61487
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
