yonghong-song marked an inline comment as done. yonghong-song added inline comments.
================ Comment at: test/CodeGen/bpf-offsetreloc.c:2-4 +// RUN: grep "llvm.preserve.struct.access.index" %t1 +// RUN: grep "llvm.preserve.array.access.index" %t1 +// RUN: grep "llvm.preserve.union.access.index" %t1 ---------------- lebedev.ri wrote: > This looks like a bad test. > Can't you use FileCheck? > I'd think there is more to test than a single tiny test.. Thanks. I will add more tests with FileCheck once we get an agreement for the general approach. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llvm.org/D61809 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
