craig.topper added inline comments.
================
Comment at: lib/Headers/avx512vlvp2intersectintrin.h:39
+
+static __inline__ void __DEFAULT_FN_ATTRS256
+_mm256_2intersect_epi32(__m256i __a, __m256i __b, __mmask8 *__m0, __mmask8
*__m1) {
----------------
xiangzhangllvm wrote:
> craig.topper wrote:
> > Can you add doxygen comments for the new intrinsics? @RKSimon has been
> > asking for it on other reviews. I forgot to say something in our internal
> > review.
> OK! But I really find many ntrinsicxxx.h have no doxygen comments, Is it like
> this format: ?
>
>
> ```
> /// Rounds up each element of the 128-bit vector of [4 x float] to an
> /// integer and returns the rounded values in a 128-bit vector of
> /// [4 x float].
> ///
> /// \headerfile <x86intrin.h>
> ///
> /// \code
> /// __m128 _mm_ceil_ps(__m128 X);
> /// \endcode
> ///
> /// This intrinsic corresponds to the <c> VROUNDPS / ROUNDPS </c> instruction.
> ///
> /// \param X
> /// A 128-bit vector of [4 x float] values to be rounded up.
> /// \returns A 128-bit vector of [4 x float] containing the rounded values.
> #define _mm_ceil_ps(X) _mm_round_ps((X), _MM_FROUND_CEIL)
> ```
>
Yeah that looks right. Someone was kind enough to provide comments for some of
the header files a few years ago, but it wasn't complete. I know avx512*
especially are missing comments.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62367/new/
https://reviews.llvm.org/D62367
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
