On Tue, Feb 2, 2016 at 11:15 AM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> > > On Tue, Feb 2, 2016 at 11:11 AM, Rafael EspĂndola < > cfe-commits@lists.llvm.org> wrote: > >> Out of curiosity, what technique were you using to find out if the >> headers were self-contained? Just "clang -c foo.h"? >> > > Building LLVM & Clang with C++ modules enabled > Takumi, is there a reason that your bot was not finding these issues? -- Sean Silva > > >> >> Cheers, >> Rafael >> >> >> On 2 February 2016 at 09:24, Benjamin Kramer via cfe-commits >> <cfe-commits@lists.llvm.org> wrote: >> > Author: d0k >> > Date: Tue Feb 2 08:24:21 2016 >> > New Revision: 259507 >> > >> > URL: http://llvm.org/viewvc/llvm-project?rev=259507&view=rev >> > Log: >> > Make the remaining headers self-contained. >> > >> > Modified: >> > cfe/trunk/include/clang/AST/BaseSubobject.h >> > cfe/trunk/include/clang/AST/DeclOpenMP.h >> > cfe/trunk/include/clang/AST/Mangle.h >> > cfe/trunk/include/clang/AST/TemplateName.h >> > cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h >> > cfe/trunk/include/clang/Sema/ObjCMethodList.h >> > cfe/trunk/include/clang/Sema/Ownership.h >> > cfe/trunk/include/clang/Sema/Scope.h >> > cfe/trunk/include/clang/Sema/SemaLambda.h >> > cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h >> > cfe/trunk/lib/CodeGen/CodeGenTBAA.h >> > >> > Modified: cfe/trunk/include/clang/AST/BaseSubobject.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/BaseSubobject.h?rev=259507&r1=259506&r2=259507&view=diff >> > >> ============================================================================== >> > --- cfe/trunk/include/clang/AST/BaseSubobject.h (original) >> > +++ cfe/trunk/include/clang/AST/BaseSubobject.h Tue Feb 2 08:24:21 2016 >> > @@ -15,13 +15,12 @@ >> > #define LLVM_CLANG_AST_BASESUBOBJECT_H >> > >> > #include "clang/AST/CharUnits.h" >> > +#include "clang/AST/DeclCXX.h" >> > #include "llvm/ADT/DenseMap.h" >> > #include "llvm/Support/DataTypes.h" >> > #include "llvm/Support/type_traits.h" >> > >> > namespace clang { >> > - class CXXRecordDecl; >> > - >> > // BaseSubobject - Uniquely identifies a direct or indirect base class. >> > // Stores both the base class decl and the offset from the most >> derived class to >> > // the base class. Used for vtable and VTT generation. >> > >> > Modified: cfe/trunk/include/clang/AST/DeclOpenMP.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclOpenMP.h?rev=259507&r1=259506&r2=259507&view=diff >> > >> ============================================================================== >> > --- cfe/trunk/include/clang/AST/DeclOpenMP.h (original) >> > +++ cfe/trunk/include/clang/AST/DeclOpenMP.h Tue Feb 2 08:24:21 2016 >> > @@ -17,6 +17,7 @@ >> > >> > #include "clang/AST/DeclBase.h" >> > #include "llvm/ADT/ArrayRef.h" >> > +#include "llvm/Support/TrailingObjects.h" >> > >> > namespace clang { >> > class Expr; >> > >> > Modified: cfe/trunk/include/clang/AST/Mangle.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Mangle.h?rev=259507&r1=259506&r2=259507&view=diff >> > >> ============================================================================== >> > --- cfe/trunk/include/clang/AST/Mangle.h (original) >> > +++ cfe/trunk/include/clang/AST/Mangle.h Tue Feb 2 08:24:21 2016 >> > @@ -14,6 +14,7 @@ >> > #ifndef LLVM_CLANG_AST_MANGLE_H >> > #define LLVM_CLANG_AST_MANGLE_H >> > >> > +#include "clang/AST/Decl.h" >> > #include "clang/AST/Type.h" >> > #include "clang/Basic/ABI.h" >> > #include "llvm/ADT/DenseMap.h" >> > >> > Modified: cfe/trunk/include/clang/AST/TemplateName.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/TemplateName.h?rev=259507&r1=259506&r2=259507&view=diff >> > >> ============================================================================== >> > --- cfe/trunk/include/clang/AST/TemplateName.h (original) >> > +++ cfe/trunk/include/clang/AST/TemplateName.h Tue Feb 2 08:24:21 2016 >> > @@ -14,6 +14,7 @@ >> > #ifndef LLVM_CLANG_AST_TEMPLATENAME_H >> > #define LLVM_CLANG_AST_TEMPLATENAME_H >> > >> > +#include "clang/AST/NestedNameSpecifier.h" >> > #include "clang/Basic/LLVM.h" >> > #include "llvm/ADT/FoldingSet.h" >> > #include "llvm/ADT/PointerUnion.h" >> > >> > Modified: cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h?rev=259507&r1=259506&r2=259507&view=diff >> > >> ============================================================================== >> > --- cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h (original) >> > +++ cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h Tue Feb 2 >> 08:24:21 2016 >> > @@ -15,6 +15,7 @@ >> > >> > #include "clang-c/Index.h" >> > #include "clang/AST/CanonicalType.h" >> > +#include "clang/AST/DeclBase.h" >> > #include "clang/AST/Type.h" >> > #include "clang/Sema/CodeCompleteOptions.h" >> > #include "llvm/ADT/DenseMap.h" >> > >> > Modified: cfe/trunk/include/clang/Sema/ObjCMethodList.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/ObjCMethodList.h?rev=259507&r1=259506&r2=259507&view=diff >> > >> ============================================================================== >> > --- cfe/trunk/include/clang/Sema/ObjCMethodList.h (original) >> > +++ cfe/trunk/include/clang/Sema/ObjCMethodList.h Tue Feb 2 08:24:21 >> 2016 >> > @@ -14,6 +14,7 @@ >> > #ifndef LLVM_CLANG_SEMA_OBJCMETHODLIST_H >> > #define LLVM_CLANG_SEMA_OBJCMETHODLIST_H >> > >> > +#include "clang/AST/DeclObjC.h" >> > #include "llvm/ADT/PointerIntPair.h" >> > >> > namespace clang { >> > >> > Modified: cfe/trunk/include/clang/Sema/Ownership.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/Ownership.h?rev=259507&r1=259506&r2=259507&view=diff >> > >> ============================================================================== >> > --- cfe/trunk/include/clang/Sema/Ownership.h (original) >> > +++ cfe/trunk/include/clang/Sema/Ownership.h Tue Feb 2 08:24:21 2016 >> > @@ -14,6 +14,7 @@ >> > #ifndef LLVM_CLANG_SEMA_OWNERSHIP_H >> > #define LLVM_CLANG_SEMA_OWNERSHIP_H >> > >> > +#include "clang/AST/Expr.h" >> > #include "clang/Basic/LLVM.h" >> > #include "llvm/ADT/ArrayRef.h" >> > #include "llvm/ADT/PointerIntPair.h" >> > >> > Modified: cfe/trunk/include/clang/Sema/Scope.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/Scope.h?rev=259507&r1=259506&r2=259507&view=diff >> > >> ============================================================================== >> > --- cfe/trunk/include/clang/Sema/Scope.h (original) >> > +++ cfe/trunk/include/clang/Sema/Scope.h Tue Feb 2 08:24:21 2016 >> > @@ -14,6 +14,7 @@ >> > #ifndef LLVM_CLANG_SEMA_SCOPE_H >> > #define LLVM_CLANG_SEMA_SCOPE_H >> > >> > +#include "clang/AST/Decl.h" >> > #include "clang/Basic/Diagnostic.h" >> > #include "llvm/ADT/PointerIntPair.h" >> > #include "llvm/ADT/SmallPtrSet.h" >> > >> > Modified: cfe/trunk/include/clang/Sema/SemaLambda.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/SemaLambda.h?rev=259507&r1=259506&r2=259507&view=diff >> > >> ============================================================================== >> > --- cfe/trunk/include/clang/Sema/SemaLambda.h (original) >> > +++ cfe/trunk/include/clang/Sema/SemaLambda.h Tue Feb 2 08:24:21 2016 >> > @@ -18,7 +18,7 @@ >> > #include "clang/AST/ASTLambda.h" >> > #include "clang/Sema/ScopeInfo.h" >> > namespace clang { >> > - >> > +class Sema; >> > >> > /// \brief Examines the FunctionScopeInfo stack to determine the >> nearest >> > /// enclosing lambda (to the current lambda) that is 'capture-capable' >> for >> > >> > Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h?rev=259507&r1=259506&r2=259507&view=diff >> > >> ============================================================================== >> > --- cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h (original) >> > +++ cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h Tue Feb 2 08:24:21 2016 >> > @@ -18,14 +18,14 @@ >> > #include "clang/Basic/OpenMPKinds.h" >> > #include "clang/Basic/SourceLocation.h" >> > #include "llvm/ADT/DenseMap.h" >> > -#include "llvm/ADT/DenseSet.h" >> > +#include "llvm/ADT/SmallPtrSet.h" >> > #include "llvm/ADT/StringMap.h" >> > +#include "llvm/IR/Function.h" >> > #include "llvm/IR/ValueHandle.h" >> > >> > namespace llvm { >> > class ArrayType; >> > class Constant; >> > -class Function; >> > class FunctionType; >> > class GlobalVariable; >> > class StructType; >> > @@ -530,7 +530,7 @@ private: >> > const llvm::Twine &Name); >> > >> > /// \brief Set of threadprivate variables with the generated >> initializer. >> > - llvm::DenseSet<const VarDecl *> ThreadPrivateWithDefinition; >> > + llvm::SmallPtrSet<const VarDecl *, 4> ThreadPrivateWithDefinition; >> > >> > /// \brief Emits initialization code for the threadprivate variables. >> > /// \param VDAddr Address of the global variable \a VD. >> > >> > Modified: cfe/trunk/lib/CodeGen/CodeGenTBAA.h >> > URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenTBAA.h?rev=259507&r1=259506&r2=259507&view=diff >> > >> ============================================================================== >> > --- cfe/trunk/lib/CodeGen/CodeGenTBAA.h (original) >> > +++ cfe/trunk/lib/CodeGen/CodeGenTBAA.h Tue Feb 2 08:24:21 2016 >> > @@ -15,14 +15,11 @@ >> > #ifndef LLVM_CLANG_LIB_CODEGEN_CODEGENTBAA_H >> > #define LLVM_CLANG_LIB_CODEGEN_CODEGENTBAA_H >> > >> > +#include "clang/AST/Type.h" >> > #include "clang/Basic/LLVM.h" >> > #include "llvm/ADT/DenseMap.h" >> > #include "llvm/IR/MDBuilder.h" >> > - >> > -namespace llvm { >> > - class LLVMContext; >> > - class MDNode; >> > -} >> > +#include "llvm/IR/Metadata.h" >> > >> > namespace clang { >> > class ASTContext; >> > >> > >> > _______________________________________________ >> > cfe-commits mailing list >> > cfe-commits@lists.llvm.org >> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits