svenvh added a comment. Looks good overall, I'd like to propose a few more minor changes to this patch before landing:
- isPointer can be a `bit` / `bool` instead of an `int` / `unsigned`. - Renaming the command line option from `-fadd-declare-builtins` to `-fdeclare-opencl-builtins` should hopefully convey the meaning of the option a bit better. - Drop the spurious `;` in `OCL2Qual`. - Emit spaces instead of tabs for `OCL2Qual`, like the rest of the generated file. - Bring the format of OpenCL spec references into alignment with the rest of clang (e.g. OpenCL v2.0 s9.17.3). - Adding //(experimental)// to the help text of `-fdeclare-opencl-builtins`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60763/new/ https://reviews.llvm.org/D60763 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
