ostannard added inline comments.
================ Comment at: llvm/lib/Support/ARMTargetParser.cpp:551 + + // If the default FPU already supports double-precision, or if + // there is no double-prec FPU that extends it, then "fp.dp" ---------------- Could you also add tests for the error cases here? I think these are: * +fp.dp, but the FPU is already double-precision * +fp.dp, but no double-precision FPU exists (are there any FPUs which cause this?) * +[no]fp or +[no]fp.dp for a CPU/arch which doesn't have any FPUs. I also don't see any tests for the negated forms of either feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60697/new/ https://reviews.llvm.org/D60697 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
