aaronpuchert marked an inline comment as done. aaronpuchert added a comment.
In D59673#1521413 <https://reviews.llvm.org/D59673#1521413>, @dblaikie wrote: > Might be easier as a few patches - renaming the existing option, adding the > new one, then removing the single split dwarf flag handling in favor of > implying that by the absence of an output file name. No problem, makes sense to me. I'll see if it's possible to separate these changes. > if I'm reading what this patch does Yes, that seems to be how `llc` behaves, and I want to copy that. ================ Comment at: lib/CodeGen/BackendUtil.cpp:847 default: - if (!CodeGenOpts.SplitDwarfFile.empty() && - (CodeGenOpts.getSplitDwarfMode() == CodeGenOptions::SplitFileFission)) { - DwoOS = openOutputFile(CodeGenOpts.SplitDwarfFile); + if (CodeGenOpts.EnableSplitDwarf && !CodeGenOpts.SplitDwarfOutput.empty()) { + DwoOS = openOutputFile(CodeGenOpts.SplitDwarfOutput); ---------------- dblaikie wrote: > Why did this add a check for EnableSplitDwarf here that wasn't there before? I just changed the order, the check was there as `(CodeGenOpts.getSplitDwarfMode() == CodeGenOptions::SplitFileFission)` in the second line of the `if`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
