hintonda marked an inline comment as done. hintonda added inline comments.
================ Comment at: cfe/trunk/lib/Analysis/plugins/CMakeLists.txt:1 +if(LLVM_ENABLE_PLUGINS) + add_subdirectory(SampleAnalyzer) ---------------- hintonda wrote: > nathanchance wrote: > > I think this should have a dependency on `CLANG_ENABLE_STATIC_ANALYZER` > > like in `clang/test/CMakeLists.txt`, otherwise my build (which disables > > `CLANG_ENABLE_STATIC_ANALYZER`) fails because these plugins are being added > > to the build. > > > > ``` > > [2058/2605] Linking CXX shared module > > lib/CheckerOptionHandlingAnalyzerPlugin.so > > FAILED: lib/CheckerOptionHandlingAnalyzerPlugin.so > > : && /usr/bin/g++ -fPIC -O2 -march=native -mtune=native -fPIC > > -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -w > > -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common > > -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -Wl,-z,nodelete > > -fuse-ld=gold -Wl,-O3 -Wl,--gc-sections > > -Wl,--version-script,"/tc-build2/build/llvm/stage1/tools/clang/lib/Analysis/plugins/CheckerOptionHandling/CheckerOptionHandlingAnalyzerPlugin.exports" > > -shared -o lib/CheckerOptionHandlingAnalyzerPlugin.so > > tools/clang/lib/Analysis/plugins/CheckerOptionHandling/CMakeFiles/CheckerOptionHandlingAnalyzerPlugin.dir/CheckerOptionHandling.cpp.o > > -Wl,-rpath,"\$ORIGIN/../lib" lib/libLLVMSupport.a lib/libclangAnalysis.a > > lib/libclangAST.a -lclangStaticAnalyzerCore -lclangStaticAnalyzerFrontend > > lib/libLLVMSupport.a lib/libclangASTMatchers.a lib/libclangAST.a > > lib/libclangLex.a lib/libclangBasic.a lib/libLLVMCore.a > > lib/libLLVMRemarks.a lib/libLLVMMC.a lib/libLLVMBinaryFormat.a > > lib/libLLVMDebugInfoCodeView.a lib/libLLVMDebugInfoMSF.a > > lib/libLLVMSupport.a -lz -lrt -ldl -lpthread -lm lib/libLLVMDemangle.a && : > > /usr/bin/ld.gold: error: cannot find -lclangStaticAnalyzerCore > > /usr/bin/ld.gold: error: cannot find -lclangStaticAnalyzerFrontend > > collect2: error: ld returned 1 exit status > > [2059/2605] Building CXX object > > tools/clang/tools/clang-refactor/CMakeFiles/clang-refactor.dir/TestSupport.cpp.o > > [2060/2605] Linking CXX shared module > > lib/CheckerDependencyHandlingAnalyzerPlugin.so > > FAILED: lib/CheckerDependencyHandlingAnalyzerPlugin.so > > : && /usr/bin/g++ -fPIC -O2 -march=native -mtune=native -fPIC > > -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -w > > -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common > > -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -Wl,-z,nodelete > > -fuse-ld=gold -Wl,-O3 -Wl,--gc-sections > > -Wl,--version-script,"/tc-build2/build/llvm/stage1/tools/clang/lib/Analysis/plugins/CheckerDependencyHandling/CheckerDependencyHandlingAnalyzerPlugin.exports" > > -shared -o lib/CheckerDependencyHandlingAnalyzerPlugin.so > > tools/clang/lib/Analysis/plugins/CheckerDependencyHandling/CMakeFiles/CheckerDependencyHandlingAnalyzerPlugin.dir/CheckerDependencyHandling.cpp.o > > -Wl,-rpath,"\$ORIGIN/../lib" lib/libLLVMSupport.a lib/libclangAnalysis.a > > lib/libclangAST.a -lclangStaticAnalyzerCore -lclangStaticAnalyzerFrontend > > lib/libLLVMSupport.a lib/libclangASTMatchers.a lib/libclangAST.a > > lib/libclangLex.a lib/libclangBasic.a lib/libLLVMCore.a > > lib/libLLVMRemarks.a lib/libLLVMMC.a lib/libLLVMBinaryFormat.a > > lib/libLLVMDebugInfoCodeView.a lib/libLLVMDebugInfoMSF.a > > lib/libLLVMSupport.a -lz -lrt -ldl -lpthread -lm lib/libLLVMDemangle.a && : > > /usr/bin/ld.gold: error: cannot find -lclangStaticAnalyzerCore > > /usr/bin/ld.gold: error: cannot find -lclangStaticAnalyzerFrontend > > collect2: error: ld returned 1 exit status > > [2061/2605] Building CXX object > > tools/clang/lib/Tooling/CMakeFiles/obj.clangTooling.dir/CompilationDatabase.cpp.o > > [2062/2605] Linking CXX shared module lib/SampleAnalyzerPlugin.so > > FAILED: lib/SampleAnalyzerPlugin.so > > : && /usr/bin/g++ -fPIC -O2 -march=native -mtune=native -fPIC > > -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -w > > -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common > > -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -Wl,-z,nodelete > > -fuse-ld=gold -Wl,-O3 -Wl,--gc-sections > > -Wl,--version-script,"/tc-build2/build/llvm/stage1/tools/clang/lib/Analysis/plugins/SampleAnalyzer/SampleAnalyzerPlugin.exports" > > -shared -o lib/SampleAnalyzerPlugin.so > > tools/clang/lib/Analysis/plugins/SampleAnalyzer/CMakeFiles/SampleAnalyzerPlugin.dir/MainCallChecker.cpp.o > > -Wl,-rpath,"\$ORIGIN/../lib" lib/libLLVMSupport.a lib/libclangAnalysis.a > > lib/libclangAST.a -lclangStaticAnalyzerCore -lclangStaticAnalyzerFrontend > > lib/libLLVMSupport.a lib/libclangASTMatchers.a lib/libclangAST.a > > lib/libclangLex.a lib/libclangBasic.a lib/libLLVMCore.a > > lib/libLLVMRemarks.a lib/libLLVMMC.a lib/libLLVMBinaryFormat.a > > lib/libLLVMDebugInfoCodeView.a lib/libLLVMDebugInfoMSF.a > > lib/libLLVMSupport.a -lz -lrt -ldl -lpthread -lm lib/libLLVMDemangle.a && : > > /usr/bin/ld.gold: error: cannot find -lclangStaticAnalyzerCore > > /usr/bin/ld.gold: error: cannot find -lclangStaticAnalyzerFrontend > > collect2: error: ld returned 1 exit status > > ``` > Sounds reasonable, and sorry for the breakage -- I'll post a fix shortly. Fixed in r362555. Thanks again for reporting this... Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/ https://reviews.llvm.org/D62445 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
