hubert.reinterpretcast added inline comments. /cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 I'm not particularly concerned about the scoping of the work; however, the `ppc_wrappers` directory is not at all indicative of that scoping. It neither indicates the scope in terms of purpose (providing x86 vector intrinsics) nor does it indicate the scope in terms of applicability (64-bit Linux). I would suggest that the header belongs as part of a deeper structure that can be used for other purposes as well `ppc_wrappers/ppc64common/linux/`. If the header becomes applicable to more platforms, we can move it with the possibility of additionally placing headers that use `#include_next` as appropriate.
https://reviews.llvm.org/rL358949 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
