ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land.
LGTM with one change. ================ Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:294 + std::vector<StringRef> FeaturesAfter; + ---------------- You explained it in the commit message, but I think this could do with a comment in the code too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62998/new/ https://reviews.llvm.org/D62998 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
