hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added inline comments.
================ Comment at: test/Preprocessor/cuda-types.cu:11 // RUN: %clang --cuda-host-only -nocudainc -target i386-unknown-linux-gnu -x cuda -E -dM -o - /dev/null \ -// RUN: | grep 'define __[^ ]*\(TYPE\|MAX\|SIZEOF|WIDTH\)\|define __GCC_ATOMIC' \ -// RUN: | grep -v '__LDBL\|_LONG_DOUBLE' > %t/i386-host-defines-filtered +// RUN: | grep -E 'define __[^ ]*(TYPE|MAX|SIZEOF\|WIDTH)|define __GCC_ATOMIC' \ +// RUN: | grep -Ev '__LDBL|_LONG_DOUBLE' > %t/i386-host-defines-filtered ---------------- hubert.reinterpretcast wrote: > tra wrote: > > I believe that was a typo in the original test. It should be > > `TYPE|MAX|SIZEOF|WIDTH` now. > > `SIZEOF` and `WIDTH` are parts of different defines we're looking for. > > > > E.g > > ``` > > #define __SIZEOF_DOUBLE__ 8 > > ... > > #define __INTPTR_WIDTH__ 32 > > > > ``` > I can give that a try. I'll update on the status of whether the test passes > once `SIZEOF` and `WIDTH` is actually tested. The test still passes after updating the pattern to pick up `SIZEOF` and `WIDTH` macros. I've updated the patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63029/new/ https://reviews.llvm.org/D63029 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
