aaronpuchert marked an inline comment as done.
aaronpuchert added inline comments.
================
Comment at: include/clang/Basic/CodeGenOptions.def:263
-ENUM_CODEGENOPT(SplitDwarfMode, DwarfFissionKind, 2, NoFission) ///< DWARF
fission mode to use.
+CODEGENOPT(EnableSplitDwarf, 1, 0) ///< Whether to enable split DWARF.
----------------
dblaikie wrote:
> Could we skip this and rely on "SplitDwarFile" being non-empty?
I think not, have a look at test/CodeGen/split-debug-filename.c:
```
// RUN: %clang_cc1 -debug-info-kind=limited -split-dwarf-file foo.dwo -S
-emit-llvm -o - %s | FileCheck %s
// RUN: %clang_cc1 -debug-info-kind=limited -enable-split-dwarf
-split-dwarf-file foo.dwo -S -emit-llvm -o - %s | FileCheck
--check-prefix=VANILLA %s
// ...
// Testing to ensure that the dwo name gets output into the compile unit.
// CHECK: !DICompileUnit({{.*}}, splitDebugFilename: "foo.dwo"
// Testing to ensure that the dwo name is not output into the compile unit if
// it's for vanilla split-dwarf rather than split-dwarf for implicit modules.
// VANILLA-NOT: splitDebugFilename
```
This seems intentional.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63167/new/
https://reviews.llvm.org/D63167
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
