djtodoro marked an inline comment as done.
djtodoro added inline comments.

================
Comment at: lib/Frontend/CompilerInvocation.cpp:755
+      (Arch == llvm::Triple::x86 || Arch == llvm::Triple::x86_64))
+    Opts.EnableDebugEntryValues = Args.hasArg(OPT_femit_debug_entry_values);
+
----------------
probinson wrote:
> You want to disable entry-values for all targets other than X86?
@probinson Thanks for the comment!

>You want to disable entry-values for all targets other than X86?

Yes, for now. Because, if we want to support the entry-values feature for an 
architecture (other than X86), we would need to handle target specifics of call 
arguments lowering for the architecture.

For the initial set of patches, we have accomplished to test and add support 
only for X86. We will work on supporting more architectures.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58033/new/

https://reviews.llvm.org/D58033



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to