[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr added a comment.

Thanks! Please add tests in `./unittests/Tooling/ReplacementsYamlTest.cpp`.



================
Comment at: clang/include/clang/Tooling/ReplacementsYaml.h:43
+        ReplacementText.replace(lineBreakPos, 1, "\n\n");
+        // Get the next occurrence from the current position
+        lineBreakPos = ReplacementText.find('\n', lineBreakPos + 2);
----------------
Please add comments that explain why this is the correct serialization. Please 
don't add comments that repeat the code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63482/new/

https://reviews.llvm.org/D63482



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits