compnerd added inline comments.

================
Comment at: clang/include/clang/AST/Mangle.h:248
+
+struct ASTNameGenerator {
+  std::unique_ptr<MangleContext> MC;
----------------
Please make this a `class` and hide the members, exposing just the constructor 
and the 3 methods as @aaron.ballman pointed out that this is a `struct` not a 
`class`!  I missed that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63535/new/

https://reviews.llvm.org/D63535



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to