ABataev added inline comments.
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:9227-9229
+ } else if ((*Res == OMPDeclareTargetDeclAttr::MT_Link) ||
+ (*Res == OMPDeclareTargetDeclAttr::MT_To &&
+ HasRequiresUnifiedSharedMemory)) {
----------------
Use `assert` here instead of `else if` and remove `else` with `llvm_unreachable`
================
Comment at: lib/CodeGen/CGOpenMPRuntime.h:1125
+ /// clause OR as declare target with to clause and unified memory.
+ virtual Address getAddrOfDeclareTargetClause(const VarDecl *VD);
----------------
ABataev wrote:
> Better to name it `getAddrOfDeclareTargetVar`
Not renamed
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63108/new/
https://reviews.llvm.org/D63108
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
