rupprecht created this revision. rupprecht added reviewers: rnk, akhuang, aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits.
Depending on how clang is built, it may discard the IR names and use names like `%2` instead of `%result.ptr`, causing tests that rely on the IR name to fail. Using `fno-discard-value-names` ensures the actual name is present regardless of the build mode. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63625 Files: clang/test/CodeGenCXX/debug-info-nrvo.cpp Index: clang/test/CodeGenCXX/debug-info-nrvo.cpp =================================================================== --- clang/test/CodeGenCXX/debug-info-nrvo.cpp +++ clang/test/CodeGenCXX/debug-info-nrvo.cpp @@ -1,5 +1,10 @@ -// RUN: %clangxx -target x86_64-unknown-unknown -g %s -emit-llvm -S -o - | FileCheck %s -// RUN: %clangxx -target x86_64-unknown-unknown -g -fno-elide-constructors %s -emit-llvm -S -o - | FileCheck %s -check-prefix=NOELIDE +// RUN: %clangxx -target x86_64-unknown-unknown -g -fno-discard-value-names \ +// RUN: %s -emit-llvm -S -o - | FileCheck %s + +// RUN: %clangxx -target x86_64-unknown-unknown -g -fno-discard-value-names \ +// RUN: -fno-elide-constructors %s -emit-llvm -S -o - | \ +// RUN: FileCheck %s -check-prefix=NOELIDE + struct Foo { Foo() = default; Foo(Foo &&other) { x = other.x; }
Index: clang/test/CodeGenCXX/debug-info-nrvo.cpp =================================================================== --- clang/test/CodeGenCXX/debug-info-nrvo.cpp +++ clang/test/CodeGenCXX/debug-info-nrvo.cpp @@ -1,5 +1,10 @@ -// RUN: %clangxx -target x86_64-unknown-unknown -g %s -emit-llvm -S -o - | FileCheck %s -// RUN: %clangxx -target x86_64-unknown-unknown -g -fno-elide-constructors %s -emit-llvm -S -o - | FileCheck %s -check-prefix=NOELIDE +// RUN: %clangxx -target x86_64-unknown-unknown -g -fno-discard-value-names \ +// RUN: %s -emit-llvm -S -o - | FileCheck %s + +// RUN: %clangxx -target x86_64-unknown-unknown -g -fno-discard-value-names \ +// RUN: -fno-elide-constructors %s -emit-llvm -S -o - | \ +// RUN: FileCheck %s -check-prefix=NOELIDE + struct Foo { Foo() = default; Foo(Foo &&other) { x = other.x; }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits