Eugene.Zelenko added inline comments.
================ Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:21 namespace { ---------------- Anonymous namespace is used for functions when LLVM Coding Guidelines tells using static for same purpose. ================ Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:31 + const llvm::StringMap<std::string> &Options) { + std::string OptionsText = ""; + for (auto &Option : Options) { ---------------- You don't need to assign empty string. See [[ https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-string-init.html | readability-redundant-string-init ]]. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63663/new/ https://reviews.llvm.org/D63663 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits