rsmith added a comment. `PPCallbacks` seems to be missing the addition of `EnteredSubmodule` and `LeftSubmodule`; `PPChainedCallbacks` seems to be missing the addition of `LeftSubmodule`.
Generally this seems reasonable. ================ Comment at: lib/Lex/PPLexerChange.cpp:783 + if (Callbacks) + Callbacks->LeftSubmodule(ForPragma); + ---------------- Would it be useful to pass in the module (and maybe the import location) here? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62293/new/ https://reviews.llvm.org/D62293 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
