lildmh marked an inline comment as done. lildmh added inline comments.
================ Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:744 OMPRTL__tgt_target_data_update_nowait, + // Call to int64_t __tgt_mapper_num_components(void *rt_mapper_handle); + OMPRTL__tgt_mapper_num_components, ---------------- ABataev wrote: > lildmh wrote: > > ABataev wrote: > > > Do we really need to use `int64_t` for number of elements? `size_t` must > > > be enough. > > Because we use the return value to shift the memberof filed of map type, > > which is `int64_t`, so I think `int64_t` makes sense here. > Ok, there is a discrepancy between runtime part and compiler part: > `__tgt_push_mapper_component` uses `size_t` for size, while the runtime > function uses `int64_t`. It won't work for 32bit platform. This should work on 32bit machines, since 32bit machines also use `int64_t` for the map type? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
