Author: rjmccall Date: Fri Feb 5 15:37:38 2016 New Revision: 259932 URL: http://llvm.org/viewvc/llvm-project?rev=259932&view=rev Log: Add an ARC autoreleased-return-value caller marker on i386.
rdar://24531556 Added: cfe/trunk/test/CodeGenObjC/arc-i386.m Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/TargetInfo.cpp?rev=259932&r1=259931&r2=259932&view=diff ============================================================================== --- cfe/trunk/lib/CodeGen/TargetInfo.cpp (original) +++ cfe/trunk/lib/CodeGen/TargetInfo.cpp Fri Feb 5 15:37:38 2016 @@ -920,6 +920,11 @@ public: ('T' << 24); return llvm::ConstantInt::get(CGM.Int32Ty, Sig); } + + StringRef getARCRetainAutoreleasedReturnValueMarker() const override { + return "movl\t%ebp, %ebp" + "\t\t## marker for objc_retainAutoreleaseReturnValue"; + } }; } Added: cfe/trunk/test/CodeGenObjC/arc-i386.m URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/arc-i386.m?rev=259932&view=auto ============================================================================== --- cfe/trunk/test/CodeGenObjC/arc-i386.m (added) +++ cfe/trunk/test/CodeGenObjC/arc-i386.m Fri Feb 5 15:37:38 2016 @@ -0,0 +1,43 @@ +// RUN: %clang_cc1 -triple i386-apple-darwin10 -emit-llvm -fblocks -fobjc-arc -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple i386-apple-iossimulator6.0 -emit-llvm -fblocks -fobjc-arc -o - %s | FileCheck %s + +// <rdar://24531556>: implement objc_retainAutoreleasedReturnValue on i386 + +// CHECK-LABEL: define i8* @test0() +id test0(void) { + extern id test0_helper(void); + // CHECK: [[T0:%.*]] = call i8* @test0_helper() + // CHECK-NEXT: ret i8* [[T0]] + return test0_helper(); +} + +// CHECK-LABEL: define void @test1() +void test1(void) { + extern id test1_helper(void); + // CHECK: [[T0:%.*]] = call i8* @test1_helper() + // CHECK-NEXT: call void asm sideeffect "mov + // CHECK-NEXT: [[T1:%.*]] = call i8* @objc_retainAutoreleasedReturnValue(i8* [[T0]]) + // CHECK-NEXT: store i8* [[T1]], + // CHECK-NEXT: call void @objc_storeStrong( + // CHECK-NEXT: ret void + id x = test1_helper(); +} + +// rdar://problem/12133032 +// CHECK-LABEL: define {{.*}} @test2() +@class A; +A *test2(void) { + extern A *test2_helper(void); + // CHECK: [[T0:%.*]] = call [[A:%.*]]* @test2_helper() + // CHECK-NEXT: ret [[A]]* [[T0]] + return test2_helper(); +} + +// CHECK-LABEL: define i8* @test3() +id test3(void) { + extern A *test3_helper(void); + // CHECK: [[T0:%.*]] = call [[A]]* @test3_helper() + // CHECK-NEXT: [[T1:%.*]] = bitcast [[A]]* [[T0]] to i8* + // CHECK-NEXT: ret i8* [[T1]] + return test3_helper(); +} _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits