ostannard added a comment.

Without switching to `llvm.type.checked.load`, the optimisation would trigger 
in some cases where it shouldn't trigger, thus miscompiling the code. This is 
because it needs to know about _every_ virtual call site, if we lose the 
information about some of them then it will incorrectly think a virtual 
function is unused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63932/new/

https://reviews.llvm.org/D63932



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D63932: [... Oliver Stannard (Linaro) via Phabricator via cfe-commits
    • [PATCH] D639... Roman Lebedev via Phabricator via cfe-commits
    • [PATCH] D639... Oliver Stannard (Linaro) via Phabricator via cfe-commits
    • [PATCH] D639... Oliver Stannard (Linaro) via Phabricator via cfe-commits
    • [PATCH] D639... Peter Collingbourne via Phabricator via cfe-commits

Reply via email to