spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

I don't have much experience with the front-end and have no experience with the 
sanitizers, but the changes match my understanding for this type of 
cast/conversion, so LGTM.



================
Comment at: docs/UndefinedBehaviorSanitizer.rst:181
   -  ``-fsanitize=implicit-conversion``: Checks for suspicious
      behaviour of implicit conversions. Enables
      ``implicit-unsigned-integer-truncation``,
----------------
Independent of this patch but: 1 British behaviour in an otherwise American doc.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63793/new/

https://reviews.llvm.org/D63793



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D63793: T... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D637... Sanjay Patel via Phabricator via cfe-commits
    • [PATCH] D637... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D637... Oliver Stannard (Linaro) via Phabricator via cfe-commits
    • [PATCH] D637... Fangrui Song via Phabricator via cfe-commits

Reply via email to