hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
Looks good, please update the patch description (in git, and phabricator), mentioning why the previous solution won't work. ================ Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:71 + auto &SM = D->getASTContext().getSourceManager(); + if (!SM.isWrittenInMainFile(SM.getExpansionLoc(D->getLocation()))) { continue; ---------------- nit: remove the `{}` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63817/new/ https://reviews.llvm.org/D63817 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits