zahiraam added inline comments.
================
Comment at: include/clang/AST/Decl.h:4303
+
+ StringLiteral *getSTLUuid() { return STLUuid; }
+};
----------------
rsmith wrote:
> What does "STL" mean here?
Renamed it.
================
Comment at: lib/CodeGen/CodeGenModule.cpp:1071-1073
+ const auto ExistingRecord = Manglings.find(MangledName);
+ if (ExistingRecord != std::end(Manglings))
+ Manglings.remove(&(*ExistingRecord));
----------------
rsmith wrote:
> Was this supposed to be included in this patch? It looks like this is
> papering over a bug elsewhere.
This is the code that actually fixes the bug. The rest of the patch is to
represent uuid in the AST.
================
Comment at: lib/CodeGen/CodeGenModule.cpp:1071-1073
+ const auto ExistingRecord = Manglings.find(MangledName);
+ if (ExistingRecord != std::end(Manglings))
+ Manglings.remove(&(*ExistingRecord));
----------------
zahiraam wrote:
> rsmith wrote:
> > Was this supposed to be included in this patch? It looks like this is
> > papering over a bug elsewhere.
> This is the code that actually fixes the bug. The rest of the patch is to
> represent uuid in the AST.
Removed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D43576/new/
https://reviews.llvm.org/D43576
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
