Tyker added inline comments.
================
Comment at: clang/lib/AST/ASTImporter.cpp:8503
+llvm::Expected<APValue> ASTImporter::Import(const APValue &FromValue) {
+ APValue Result;
----------------
martong wrote:
> Looks okay, but could we have unit tests for this in ASTImporterTest.cpp?
I tested importing using the same test file as serialization
`clang/test/PCH/APValue.cpp` with `-ast-merge` which uses importing. this
prevent duplicating the test code for importing and serializing. is the
unit-test in ASTImporterTest.cpp necessary anyway ?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63640/new/
https://reviews.llvm.org/D63640
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
