vitalybuka marked 2 inline comments as done.
vitalybuka added inline comments.
================
Comment at: llvm/include/llvm/Analysis/MemorySSA.h:1109
// else.
- if (MemoryPhi *MP = dyn_cast<MemoryPhi>(Access))
+ if (const MemoryPhi *MP = dyn_cast<MemoryPhi>(Access))
return MP->getIncomingValue(ArgNo);
----------------
asbirlea wrote:
> Could changes in this file be landed separately?
> They seem unrelated and not in need of review.
It's already there r364247, i didn't rebase the patch after submit.
================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreEliminationExpGlobal.cpp:27
+static const char GlobalArgumentMemAccess[] = {
+// grep -P -o "(?<=FUNCTION_INFO: ).*" <logfile> | sort -u >
+// ../llvm-project/llvm/lib/Transforms/Scalar/DeadStoreEliminationExpData.h
----------------
glider wrote:
> Ditto.
These files should be empty. Raw diff
https://reviews.llvm.org/file/data/o6sk6gw2gqs4u4pmodrn/PHID-FILE-s6c6nsofxnqekkcvzdzs/D61879.diff
already contains them.
It's ThinLTO replacement experiments. They don't improve results enough, so I
didn't bother to create real ThinLTO stuff. Anyway it is not needed for full
LTO.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61879/new/
https://reviews.llvm.org/D61879
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
