hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
thanks, looks good. ================ Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:83 + // `Class` type. The destructor decls are handled in `VisitTypeLoc` (we will + // visit a TypeLoc where the underlying Type is a CXXRecordDecl). + if (D->getDeclName().isIdentifier() && D->getName().empty()) ---------------- this comment doesn't belong to the if statement below, should move to Line 87. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64257/new/ https://reviews.llvm.org/D64257 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits