ilya-biryukov added a comment. This is ready for another round
================ Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:25 /// A kind of a syntax node, used for implementing casts. enum class NodeKind : uint16_t { Leaf, ---------------- sammccall wrote: > there are going to be many of these. I'd suggest either sorting them all, or > breaking them into blocks (e.g. statements vs declarations vs leaf/tu/etc) > and sorting those blocks. I've added two blocks now - statements and expressions. Did not sort, though, I find the semantic grouping (loop statements close to each other) more useful, but hard to keep consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63835/new/ https://reviews.llvm.org/D63835 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits