lebedev.ri requested changes to this revision.
lebedev.ri added inline comments.
This revision now requires changes to proceed.
================
Comment at:
clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp:270
+ AllowPointerConditions(Options.get("AllowPointerConditions", false)),
+
UseUppercaseLiteralSuffix(Context->isCheckEnabled("readability-uppercase-literal-suffix"))
{}
----------------
alexfh wrote:
> Relying on enabled checks for this sort of a behavior is undesired. This sort
> of an implicit dependency will lead to problems, if, for example, a user
> wants to apply fixes check-by-check. A separate option (local for this check
> or better a global one - like `StrictMode`) would be better.
Looks like this wasn't resolved - it should still be a config option, not
hardcoded.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59859/new/
https://reviews.llvm.org/D59859
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
