thakis added inline comments.
================ Comment at: clang/include/clang/Driver/CLCompatOptions.td:250 def _SLASH_Zi : CLFlag<"Zi">, Alias<_SLASH_Z7>, - HelpText<"Alias for /Z7. Does not produce PDBs.">; + HelpText<"Like /Z7">; def _SLASH_Zp : CLJoined<"Zp">, ---------------- rnk wrote: > I liked "Alias for /Z7". The note that it doesn't produce type server PDBs > like /Zi would is interesting, but perhaps too much info for --help text. "Alias" is a fairly technical word; I figured less jargon is maybe better. There's still plenty of jargon left :) Maybe "Same as /Z7"? (I went with "like" since that's what some of the parens say) ================ Comment at: clang/include/clang/Driver/CLCompatOptions.td:294 def _SLASH_GX : CLFlag<"GX">, - HelpText<"Enable exception handling">; + HelpText<"Deprecated (like /EHsc)">; def _SLASH_GX_ : CLFlag<"GX-">, ---------------- rnk wrote: > "Deprecated in favor of /EHsc"? or "(use /EHsc instead)"? The other deprecated flags use "Deprecated (description); use /replacement". Changed to "Deprecated; use /EHsc"; description and replacement are the same here. (Except that /EH doesn't have a great help text atm.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64504/new/ https://reviews.llvm.org/D64504 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
