rjmccall added inline comments.
================ Comment at: clang/lib/Parse/ParseDecl.cpp:6587 + return; + } + ---------------- Mordante wrote: > rjmccall wrote: > > Comment indentation. > > > > Should we do this when starting to parse a function prototype instead of > > when parsing a parameter? > Thanks I noticed I forgot to change the tabs to spaces. > > I looked at your suggestion to move the code, but I think this is the proper > place. Now it also validates whether lambdas exceed the limit, else we need > to check at two places. > I'll also add a unit test to test for the lambda. I don't understand. I'm just saying to put the check at the top of the function instead of inside the loop. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://reviews.llvm.org/D63975 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
