On Thu, 11 Jul 2019 at 22:20, Shoaib Meenai via cfe-commits <cfe-commits@lists.llvm.org> wrote: > > Author: smeenai > Date: Thu Jul 11 14:20:38 2019 > New Revision: 365825 > > URL: http://llvm.org/viewvc/llvm-project?rev=365825&view=rev > Log: > [clang-shlib] Fix clang-shlib for PRIVATE dependencies > > Any static library with a PRIVATE dependency ends up with a > $<LINK_ONLY:...> generator expression in its INTERFACE_LINK_LIBRARIES, > which won't be evaluated by the $<TARGET_PROPERTY:...>, so we end up > with an unevaluated generator expression in the generated build file and > Ninja chokes on the dollar sign. Just use the static library directly > for its dependencies instead of trying to propagate dependencies > manually. > > Differential Revision: https://reviews.llvm.org/D64579
This seems to break a -DBUILD_SHARED_LIBS build for me. It fails at the point of linking lib/libclang_shared.so.9svn with errors like: ld.lld: error: undefined symbol: llvm::llvm_unreachable_internal(char const*, char const*, unsigned int) >>> referenced by Attributes.cpp:34 >>> (/home/asb/llvm-project/clang/lib/Basic/Attributes.cpp:34) >>> >>> tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Attributes.cpp.o:(clang::attr::getSubjectMatchRuleSpelling(clang::attr::SubjectMatchRule)) ld.lld: error: undefined symbol: llvm::llvm_unreachable_internal(char const*, char const*, unsigned int) >>> referenced by TargetCXXABI.h:168 >>> (/home/asb/llvm-project/clang/include/clang/Basic/TargetCXXABI.h:168) >>> >>> tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Attributes.cpp.o:(clang::TargetCXXABI::isMicrosoft() >>> const) ld.lld: error: undefined symbol: llvm::llvm_unreachable_internal(char const*, char const*, unsigned int) >>> referenced by TargetCXXABI.h:149 >>> (/home/asb/llvm-project/clang/include/clang/Basic/TargetCXXABI.h:149) >>> >>> tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Attributes.cpp.o:(clang::TargetCXXABI::isItaniumFamily() >>> const) ld.lld: error: undefined symbol: llvm::EnableABIBreakingChecks >>> referenced by Attributes.cpp >>> >>> tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Attributes.cpp.o:(llvm::VerifyEnableABIBreakingChecks) _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits