hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:36
+ // must be deduplicated.
+ std::sort(Tokens.begin(), Tokens.end());
+ for (unsigned I = 1; I < Tokens.size(); ++I) {
----------------
nit: we could write it like
```
llvm::sort(Tokens, [](const HighlightingToken &Lhs, const HighlightingToken
&Rhs) {
return std::tie(Lhs.Kind, Lhs.R) < std::tie(Rhs.Kind, Rhs.R);
});
auto Last = std::unique(Tokens.begin(), Tokens.end());
Tokens.erase(Last, Tokens.end());
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64634/new/
https://reviews.llvm.org/D64634
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
