aheejin added inline comments.
================ Comment at: lld/test/wasm/data-segments.ll:7 ; RUN: wasm-ld -no-gc-sections --no-entry --shared-memory --max-memory=131072 %t.atomics.o -o %t.atomics.wasm -; RUN: obj2yaml %t.atomics.wasm | FileCheck %s --check-prefix ACTIVE +; RUN: obj2yaml %t.atomics.wasm | FileCheck %s --check-prefixes ACTIVE,ACTIVE-TLS ---------------- quantum wrote: > aheejin wrote: > > What is the difference between `ACTIVE` and `ACTIVE-TLS`? It looks we don't > > have different build processes for them. And as what @sbc100 said, can we > > exclude TLS from build? > `ACTIVE-TLS` is for builds with TLS enabled. Currently, we use > `--shared-memory` to determine that, per @tlively's recommendation. The > rationale is that we don't want even more flags that need to be passed in a > proper threaded build. Then if we don't enable `--shared-memory`, we don't generate those globals? Do we have a test for that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
