sammccall added a comment.
Are you sure we want to disable extraction here, rather than just do the
extraction at a higher level?
E.g. if `bar(1,2,3, f[[o]]o(4,5));` seems like it should extract the call too
`foo(4,5)`, not fail to trigger entirely.
================
Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:81
+// An expr is not extractable if it's null, an expression of type void, an
+// assignment expression, MemberExpr or a DeclRefExpr
static bool isExtractableExpr(const clang::Expr *Expr) {
----------------
this comment repeats the implementation, but should explain why instead
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64717/new/
https://reviews.llvm.org/D64717
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
