martong added inline comments.
================ Comment at: include/clang/AST/ASTImporter.h:234 + /// The ASTUnit that this importer belongs to, if any. + ASTUnit *Unit; + ---------------- `Unit->getASTContext` must be equal to `FromContext`, right? Then `FromUnit` would be a better naming. The importer does handle two ASTContexts, so it would be great to know which ASTUnit's ASTContext is which. Or vica-versa, we must know precisely to which context does this unit belong. Also a comment would be useful that we must store the unit because there is no way to get that from the context. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64554/new/ https://reviews.llvm.org/D64554 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
