jvikstrom marked an inline comment as done. jvikstrom added inline comments.
================ Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:170 + return; + Loc = SM.getSpellingLoc(Loc); + } ---------------- hokein wrote: > The Loc here maybe not in the main file, considering the case > > ``` > // in .h > #define DEFINE(X) in X; > #define DEFINE_Y DEFINE(Y) > > // in .cc > > DEFINE_Y > ``` The spelling loc is still going to be in `DEFINE_Y` I think. And we only highlight arguments in macros. (Added a testcase though) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64741/new/ https://reviews.llvm.org/D64741 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
