hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
Thanks! Looks good from my side. @ilya-biryukov will be nice if you could take a second look on the patch. We plan to land it before the release cut today. ================ Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1115 + std::lock_guard<std::mutex> Lock(HighlightingsMutex); + Old = FileToHighlightings[File]; + } ---------------- use std::move() to save a copy here. we'd drop the old highlighting anyway (replace it with new highlightings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://reviews.llvm.org/D64475 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
